From cd3ab0247d5acf4df0796105f6dd02cf0160eaf5 Mon Sep 17 00:00:00 2001
From: camilogs <camilo.gonzalez.col@gmail.com>
Date: Wed, 9 Aug 2023 19:52:03 -0500
Subject: [PATCH] chore: se hacen obligatorios campos pertinentes en Prospect y
 ContactMethod

---
 prospect.py                   |  8 +++---
 tests/test_module.py          | 22 -----------------
 tests/test_required_values.py | 46 +++++++++++++++++++++++++++++++++++
 3 files changed, 50 insertions(+), 26 deletions(-)
 delete mode 100644 tests/test_module.py
 create mode 100644 tests/test_required_values.py

diff --git a/prospect.py b/prospect.py
index 6a2ccfb..b9f4c58 100644
--- a/prospect.py
+++ b/prospect.py
@@ -9,7 +9,7 @@ class Prospect(ModelSQL, ModelView):
     __name__ = 'sale.prospect'
     _rec_name = 'name'
 
-    name = fields.Char('Name')
+    name = fields.Char('Name', required=True)
 
     contact_methods = fields.One2Many(
         'prospect.contact_method',
@@ -35,13 +35,13 @@ class ContactMethod(ModelSQL, ModelView):
         ('mobile', 'Mobile'),
         ('mail', 'Mail')
     ]
-    contact_type = fields.Selection(_type, 'Contact type')
+    contact_type = fields.Selection(_type, 'Contact type', required=True)
 
-    value = fields.Char('Value')
+    value = fields.Char('Value', required=True)
     name = fields.Char('Name')
     job = fields.Char('job')
 
-    prospect = fields.Many2One('sale.prospect', 'Prospect')
+    prospect = fields.Many2One('sale.prospect', 'Prospect', required=True)
 
     def get_rec_name(self, name):
         fields = [self.name, self.job, self.value]
diff --git a/tests/test_module.py b/tests/test_module.py
deleted file mode 100644
index cc89333..0000000
--- a/tests/test_module.py
+++ /dev/null
@@ -1,22 +0,0 @@
-from trytond.tests.test_tryton import ModuleTestCase, with_transaction
-from trytond.pool import Pool
-
-
-class SaleOpportunityManagementTestCase(ModuleTestCase):
-    "Test Sale Opportunity Management module"
-    module = 'sale_opportunity_management'
-
-    @with_transaction()
-    def test_prospecto_en_prospect_trace_es_obligatorio(self):
-        pool = Pool()
-        ProspectTrace = pool.get('sale.prospect_trace')
-        self.assertTrue(ProspectTrace.prospect.required)
-
-    @with_transaction()
-    def test_contact_method_en_prospect_es_obligatorio(self):
-        pool = Pool()
-        Prospect = pool.get('sale.prospect')
-        self.assertTrue(Prospect.contact_methods.required)
-
-
-del ModuleTestCase
diff --git a/tests/test_required_values.py b/tests/test_required_values.py
new file mode 100644
index 0000000..637fb0c
--- /dev/null
+++ b/tests/test_required_values.py
@@ -0,0 +1,46 @@
+from trytond.tests.test_tryton import ModuleTestCase, with_transaction
+from trytond.pool import Pool
+
+
+class RequiredValuesTestCase(ModuleTestCase):
+    "Test Sale Opportunity Management module"
+    module = 'sale_opportunity_management'
+
+    @with_transaction()
+    def test_prospecto_en_prospect_trace_es_obligatorio(self):
+        pool = Pool()
+        ProspectTrace = pool.get('sale.prospect_trace')
+        self.assertTrue(ProspectTrace.prospect.required)
+
+    @with_transaction()
+    def test_contact_method_en_prospect_es_obligatorio(self):
+        pool = Pool()
+        Prospect = pool.get('sale.prospect')
+        self.assertTrue(Prospect.contact_methods.required)
+
+    @with_transaction()
+    def test_name_en_prospect_es_obligatorio(self):
+        pool = Pool()
+        Prospect = pool.get('sale.prospect')
+        self.assertTrue(Prospect.name.required)
+
+    @with_transaction()
+    def test_value_en_contact_method_es_obligatorio(self):
+        pool = Pool()
+        ContactMethod = pool.get('prospect.contact_method')
+        self.assertTrue(ContactMethod.value.required)
+
+    @with_transaction()
+    def test_contact_type_en_contact_method_es_obligatorio(self):
+        pool = Pool()
+        ContactMethod = pool.get('prospect.contact_method')
+        self.assertTrue(ContactMethod.contact_type.required)
+
+    @with_transaction()
+    def test_prospect_en_contact_method_es_obligatorio(self):
+        pool = Pool()
+        ContactMethod = pool.get('prospect.contact_method')
+        self.assertTrue(ContactMethod.prospect.required)
+
+
+del ModuleTestCase