Fix: Formateo PEP8 (79 cols) y limpieza flake8 en paquete facho

- Líneas >79 cols reajustadas en todo el paquete - Fix F821: etree.cleanup_namespaces(security) en signature.py (era 'header', NameError) - Fix bug cune_xpath -> xpath en nomina/informacion_general() (NameError) - Elimina clase TaxScheme duplicada en form/__init__.py - Imports explícitos (F403/F405) y __all__ en form_xml/invoice.py, nomina - Elimina imports y variables muertas (F401/F841), E712 (== None -> is None)
2026-08-12 19:56:29 -05:00
parent 26ce89ca33
commit 4a7c2e2947
37 changed files with 1915 additions and 1103 deletions
--- a/facho/fe/data/dian/XSD/init.py
+++ b/facho/fe/data/dian/XSD/init.py
@@ -7,10 +7,17 @@ def path_for_xsd(dirname, xsdname):
    data_dir = os.path.dirname(os.path.abspath(__file__))
    return os.path.join(data_dir, dirname, xsdname)

-UBLInvoice= xmlschema.XMLSchema(path_for_xsd('maindoc', 'UBL-Invoice-2.1.xsd'))

-NominaIndividual = xmlschema.XMLSchema(path_for_xsd('nomina', 'NominaIndividualElectronicaXSDV1.0.6.xsd'))
-NominaIndividualDeAjuste = xmlschema.XMLSchema(path_for_xsd('nomina', 'NominaIndividualDeAjusteElectronicaXSDV1.0.6.xsd'))
+UBLInvoice = xmlschema.XMLSchema(
+    path_for_xsd(
+        'maindoc',
+        'UBL-Invoice-2.1.xsd'))
+
+NominaIndividual = xmlschema.XMLSchema(path_for_xsd(
+    'nomina', 'NominaIndividualElectronicaXSDV1.0.6.xsd'))
+NominaIndividualDeAjuste = xmlschema.XMLSchema(path_for_xsd(
+    'nomina', 'NominaIndividualDeAjusteElectronicaXSDV1.0.6.xsd'))
+

 def validate(xml, schema):
    schema.validate(xml)
--- a/facho/fe/data/dian/codelist/init.py
+++ b/facho/fe/data/dian/codelist/init.py
@@ -20,12 +20,12 @@ class CodeList:
    def _load(self, filename, primary_column):
        tree = etree.parse(filename)

-        #obtener identificadores...
+        # obtener identificadores...
        self.short_name = tree.find('./Identification/ShortName').text
        self.long_name = tree.find('./Identification/LongName').text
        self.version = tree.find('./Identification/Version').text

-        #obtener registros...
+        # obtener registros...
        for row in tree.findall('./SimpleCodeList/Row'):
            new_row = self.xmlrow_to_dict(row)
            primary_key = new_row[primary_column]
@@ -34,7 +34,7 @@ class CodeList:
    def xmlrow_to_dict(self, xmlrow):
        row = {}

-        #construir registro...
+        # construir registro...
        for value in list(xmlrow):
            row[value.attrib['ColumnRef']] = list(value)[0].text

@@ -60,6 +60,7 @@ class CodeList:
 # nombres de variables igual a ./Identification/ShortName
 # TODO: garantizar unica carga en python

+
 __all__ = ['TipoOrganizacion',
           'TipoResponsabilidad',
           'TipoAmbiente',
@@ -72,38 +73,88 @@ __all__ = ['TipoOrganizacion',
           'Municipio',
           'Departamento']

+
 def path_for_codelist(name):
    return os.path.join(DATA_DIR, name)

-TipoOrganizacion = CodeList(path_for_codelist('TipoOrganizacion-2.1.gc'), 'code', 'name')
-TipoResponsabilidad = CodeList(path_for_codelist('TipoResponsabilidad-2.1.gc'), 'code', 'name')\
-    .update(CodeList(path_for_codelist('TipoResponsabilidad-2.1.custom.gc'), 'code', 'name'))
-TipoAmbiente = CodeList(path_for_codelist('TipoAmbiente-2.1.gc'), 'code', 'name')
-TipoDocumento = CodeList(path_for_codelist('TipoDocumento-2.1.gc'), 'code', 'name')
-TipoImpuesto = CodeList(path_for_codelist('TipoImpuesto-2.1.gc'), 'code', 'name')\
-    .update(CodeList(path_for_codelist('TipoImpuesto-2.1.custom.gc'), 'code', 'name'))
-TarifaImpuesto = CodeList(path_for_codelist('TarifaImpuestoINC-2.1.gc'), 'code', 'name')\
-        .update(CodeList(path_for_codelist('TarifaImpuestoIVA-2.1.gc'), 'code', 'name'))\
-        .update(CodeList(path_for_codelist('TarifaImpuestoReteIVA-2.1.gc'), 'code', 'name'))\
-        .update(CodeList(path_for_codelist('TarifaImpuestoReteRenta-2.1.gc'), 'code', 'name'))
-CodigoPrecioReferencia = CodeList(path_for_codelist('CodigoPrecioReferencia-2.1.gc'), 'code', 'name')
+
+TipoOrganizacion = CodeList(path_for_codelist(
+    'TipoOrganizacion-2.1.gc'), 'code', 'name')
+TipoResponsabilidad = CodeList(
+    path_for_codelist('TipoResponsabilidad-2.1.gc'),
+    'code',
+    'name') .update(
+        CodeList(
+            path_for_codelist('TipoResponsabilidad-2.1.custom.gc'),
+            'code',
+            'name'))
+TipoAmbiente = CodeList(path_for_codelist(
+    'TipoAmbiente-2.1.gc'), 'code', 'name')
+TipoDocumento = CodeList(path_for_codelist(
+    'TipoDocumento-2.1.gc'), 'code', 'name')
+TipoImpuesto = CodeList(
+    path_for_codelist('TipoImpuesto-2.1.gc'),
+    'code',
+    'name') .update(
+        CodeList(
+            path_for_codelist('TipoImpuesto-2.1.custom.gc'),
+            'code',
+            'name'))
+TarifaImpuesto = CodeList(
+    path_for_codelist('TarifaImpuestoINC-2.1.gc'),
+    'code',
+    'name') .update(
+        CodeList(
+            path_for_codelist('TarifaImpuestoIVA-2.1.gc'),
+            'code',
+            'name')) .update(
+                CodeList(
+                    path_for_codelist('TarifaImpuestoReteIVA-2.1.gc'),
+                    'code',
+                    'name')) .update(
+                        CodeList(
+                            path_for_codelist(
+                                'TarifaImpuestoReteRenta-2.1.gc'),
+                            'code',
+                            'name'))
+CodigoPrecioReferencia = CodeList(path_for_codelist(
+    'CodigoPrecioReferencia-2.1.gc'), 'code', 'name')
 MediosPago = CodeList(path_for_codelist('MediosPago-2.1.gc'), 'code', 'name')
 FormasPago = CodeList(path_for_codelist('FormasPago-2.1.gc'), 'code', 'name')
-RegimenFiscal = CodeList(path_for_codelist('RegimenFiscal-2.1.custom.gc'), 'code', 'name')
-TipoOperacionNC = CodeList(path_for_codelist('TipoOperacionNC-2.1.gc'), 'code', 'name')
-TipoOperacionNCDS = CodeList(path_for_codelist('TipoOperacionNCDS-2.1.gc'), 'code', 'name')
-TipoOperacionND = CodeList(path_for_codelist('TipoOperacionND-2.1 - copia.gc'), 'code', 'name')
-TipoOperacionF = CodeList(path_for_codelist('TipoOperacionF-2.1.gc'), 'code', 'name')\
-    .update(CodeList(path_for_codelist('TipoOperacionF-2.1.custom.gc'), 'code', 'name'))
+RegimenFiscal = CodeList(path_for_codelist(
+    'RegimenFiscal-2.1.custom.gc'), 'code', 'name')
+TipoOperacionNC = CodeList(path_for_codelist(
+    'TipoOperacionNC-2.1.gc'), 'code', 'name')
+TipoOperacionNCDS = CodeList(path_for_codelist(
+    'TipoOperacionNCDS-2.1.gc'), 'code', 'name')
+TipoOperacionND = CodeList(path_for_codelist(
+    'TipoOperacionND-2.1 - copia.gc'), 'code', 'name')
+TipoOperacionF = CodeList(
+    path_for_codelist('TipoOperacionF-2.1.gc'),
+    'code',
+    'name') .update(
+        CodeList(
+            path_for_codelist('TipoOperacionF-2.1.custom.gc'),
+            'code',
+            'name'))
 Municipio = CodeList(path_for_codelist('Municipio-2.1.gc'), 'code', 'name')
-Departamento = CodeList(path_for_codelist('Departamentos-2.1.gc'), 'code', 'name')
+Departamento = CodeList(path_for_codelist(
+    'Departamentos-2.1.gc'), 'code', 'name')
 Paises = CodeList(path_for_codelist('Paises-2.1.gc'), 'code', 'name')
-TipoIdFiscal = CodeList(path_for_codelist('TipoIdFiscal-2.1.gc'), 'code', 'name')
-CodigoDescuento = CodeList(path_for_codelist('CodigoDescuento-2.1.gc'), 'code', 'name')
-UnidadesMedida = CodeList(path_for_codelist('UnidadesMedida-2.1.gc'), 'code', 'name')
-TipoTrabajador = CodeList(path_for_codelist('TipoTrabajador-2.1.gc'), 'code', 'name')
-SubTipoTrabajador = CodeList(path_for_codelist('SubTipoTrabajador-2.1.gc'), 'code', 'name')
-TipoContrato = CodeList(path_for_codelist('TipoContrato-2.1.gc'), 'code', 'name')
-PeriodoNomina = CodeList(path_for_codelist('PeriodoNomina-2.1.gc'), 'code', 'name')
+TipoIdFiscal = CodeList(path_for_codelist(
+    'TipoIdFiscal-2.1.gc'), 'code', 'name')
+CodigoDescuento = CodeList(path_for_codelist(
+    'CodigoDescuento-2.1.gc'), 'code', 'name')
+UnidadesMedida = CodeList(path_for_codelist(
+    'UnidadesMedida-2.1.gc'), 'code', 'name')
+TipoTrabajador = CodeList(path_for_codelist(
+    'TipoTrabajador-2.1.gc'), 'code', 'name')
+SubTipoTrabajador = CodeList(path_for_codelist(
+    'SubTipoTrabajador-2.1.gc'), 'code', 'name')
+TipoContrato = CodeList(path_for_codelist(
+    'TipoContrato-2.1.gc'), 'code', 'name')
+PeriodoNomina = CodeList(path_for_codelist(
+    'PeriodoNomina-2.1.gc'), 'code', 'name')
 TipoMoneda = CodeList(path_for_codelist('TipoMoneda-2.1.gc'), 'code', 'name')
-IdiomaISO6391 = CodeList(path_for_codelist('Idioma-2.1.gc'), 'iso-639-1', 'name')
+IdiomaISO6391 = CodeList(path_for_codelist(
+    'Idioma-2.1.gc'), 'iso-639-1', 'name')