From 23ec2bc298961100f5ad911b659437304665b23e Mon Sep 17 00:00:00 2001 From: Mono Mono Date: Sat, 24 Aug 2024 10:30:58 -0500 Subject: [PATCH] refactor: move Products list logic to model. --- tienda_ilusion/don_confiao/models.py | 14 ++++++++++++++ tienda_ilusion/don_confiao/views.py | 13 +------------ 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/tienda_ilusion/don_confiao/models.py b/tienda_ilusion/don_confiao/models.py index 71772d1..eb7d0a9 100644 --- a/tienda_ilusion/don_confiao/models.py +++ b/tienda_ilusion/don_confiao/models.py @@ -37,6 +37,20 @@ class Product(models.Model): def __str__(self): return self.name + @classmethod + def to_list(cls): + products_list = [] + all_products = cls.objects.all() + for product in all_products: + rproduct = { + "name": product.name, + "price_list": product.price, + "uom": product.measuring_unit, + "categories": [c.name for c in product.categories.all()] + } + products_list.append(rproduct) + return products_list + class Sale(models.Model): customer = models.ForeignKey(Customer, on_delete=models.PROTECT) diff --git a/tienda_ilusion/don_confiao/views.py b/tienda_ilusion/don_confiao/views.py index 63169c4..962c605 100644 --- a/tienda_ilusion/don_confiao/views.py +++ b/tienda_ilusion/don_confiao/views.py @@ -60,18 +60,7 @@ def purchases(request): def products(request): - rproducts = [] - products = Product.objects.all() - for product in products: - rproduct = { - "name": product.name, - "price_list": product.price, - "uom": product.measuring_unit, - "categories": [c.name for c in product.categories.all()] - } - rproducts.append(rproduct) - - return JsonResponse(rproducts, safe=False) + return JsonResponse(Product.to_list(), safe=False) def import_products(request):