From 032c51cc17f447a861eb4f3908f8fa604afcbd2d Mon Sep 17 00:00:00 2001
From: aserrador <alejandro.ayala@onecluster.org>
Date: Sat, 7 Mar 2026 23:52:09 -0500
Subject: [PATCH] feat: add try-except error handling in MCP tools

---
 src/tryton_mcp/server.py | 59 ++++++++++++++++++++++++----------------
 1 file changed, 36 insertions(+), 23 deletions(-)

diff --git a/src/tryton_mcp/server.py b/src/tryton_mcp/server.py
index 1fc155d..1eaf710 100644
--- a/src/tryton_mcp/server.py
+++ b/src/tryton_mcp/server.py
@@ -4,7 +4,7 @@ MCP Server for Naliia Module
 
 from contextlib import asynccontextmanager
 from fastmcp import FastMCP
-from typing import List, AsyncIterator
+from typing import List, AsyncIterator, Any, Dict
 import datetime
 
 from tryton_mcp.config import settings
@@ -20,6 +20,15 @@ async def server_lifespan(server: FastMCP) -> AsyncIterator[None]:
 mcp = FastMCP("Tryton MCP Server", lifespan=server_lifespan)
 
 
+def tryton_call(name: str, args: list) -> Dict[str, Any]:
+    try:
+        client = settings.get_client()
+        response = client.call(name, args)
+        return {"success": True, "data": response}
+    except Exception as e:
+        return {"success": False, "error": str(e)}
+
+
 @mcp.tool()
 def create_schedule(
     professional: int, description: str, customer: int, date: str, service_center: int
@@ -35,38 +44,42 @@ def create_schedule(
         }
     ]
 
-    client = settings.get_client()
-    name = "model.naliia.schedule.create"
-    args = [example_schedule, {}]
-    response = client.call(name, args)
+    result = tryton_call("model.naliia.schedule.create", [example_schedule, {}])
 
-    return response
+    if not result["success"]:
+        raise Exception(f"Failed to create schedule: {result['error']}")
+
+    return result["data"]
 
 
 @mcp.tool()
 def find_service_centers():
-    client = settings.get_client()
+    result = tryton_call(
+        "model.naliia.service_center.search_read",
+        [[[]], 0, None, None, ["name", "address.street"], {}],
+    )
 
-    name = "model.naliia.service_center.search_read"
-    args = [[[]], 0, None, None, ["name", "address.street"], {}]
-    response = client.call(name, args)
+    if not result["success"]:
+        raise Exception(f"Failed to find service centers: {result['error']}")
 
-    return response
+    return result["data"]
 
 
 @mcp.tool()
 def find_products_and_services():
-    client = settings.get_client()
+    result = tryton_call(
+        "model.product.product.search_read",
+        [
+            [["active", "=", True], ["salable", "=", True]],
+            0,
+            None,
+            None,
+            ["name", "list_price", "description"],
+            {"company": 1},
+        ],
+    )
 
-    name = "model.product.product.search_read"
-    args = [
-        [["active", "=", True], ["salable", "=", True]],
-        0,
-        None,
-        None,
-        ["name", "list_price", "description"],
-        {"company": 1},
-    ]
-    response = client.call(name, args)
+    if not result["success"]:
+        raise Exception(f"Failed to find products: {result['error']}")
 
-    return response
+    return result["data"]